> -----Original Message-----
> From: Stefan Küng [mailto:tortoisesvn_at_gmail.com]
> Sent: zondag 24 februari 2013 20:55
> To: dev_at_subversion.apache.org
> Subject: Re: svn add and inconsistent line endings
>
> On 24.02.2013 20:45, Branko Čibej wrote:
> > On 24.02.2013 19:47, Stefan Küng wrote:
> >> On 24.02.2013 19:42, Branko Čibej wrote:
> >>
> >>> Regarding automatcially changing line endings -- we don't do that for a
> >>> very good reason: it's always been Subversion's policy to not touch file
> >>> contents unless explicitly told to do so. The line endings could be
> >>> inconsistent for reasons beyond Subversion's knowledge, and the
> property
> >>> might have been set erroneously. It's therefore up to the user to make
> >>> sure which is the case.
> >>
> >> I think if the property is set, then that's the ok from the user to
> >> just fix the eols.
> >
> > Well, we decided differently 10 years ago for the reasons I listed
> > above, and I see no new argument that would overturn that reasoning.
>
> The reason being that the user gets his work interrupted by an error
> which can only be corrected by manually editing the file, while the user
> reasonably expects that to be corrected automatically without him to
> intervene manually or even get notified about it - after all, he set the
> eol property on the file, telling svn what eol he wants the file to have.
The only reason a user should get into this problem when committing is if he edited the file him/herself.
It is certainly not new behavior on commit. With the new svn:auto-props property the autoprops problems will be more common with 1.8+, but I think you can get in the inconsistent eol problem with at least 1.5 and probably earlier versions.
I'm working on a patch for the add scenario. The property set scenario will probably require a few more apis to be revved and I'm not going to continue there right now.
Bert
Received on 2013-02-24 22:30:08 CET