On 24.02.2013 19:29, Bert Huijben wrote:
>>> Are you sure the file is adjusted?
>>>
>>> Looking at the code it appears we just skip the check (and many others
> for
>>> other properties).
>>
>> You're right. And I just tested: even if the property is set (indicating
>> inconsistent eols should be either ignored or corrected), a commit for
>> such a file fails as well.
>>
>> Maybe someone can explain why that check is needed? Is there really a
>> situation where the svn:eol-style property is set on a file and users
>> don't want the inconsistencies in eols either ignored or fixed
>> automatically? I can't think of one such situation.
>> Because if there isn't, then why not remove that check?
>
> (Just added a regression test to confirm)
>
> In that case I would say that we should remove the file contents check on
> the local propset and leave the problem to the later commit.
> That should fix all the property problems for autoprops Branko, shouldn't
> it?
>
> I think we should still verify that the property values are valid to make it
> visible that the autoprops are not set correctly.
Agreed, I'd like to have the properties validated even if the eols are not.
> But that leaves the problem that it would be nice to have an easy fix for
> subversion clients to resolve these eol problems while committing...
I still don't know what the problem is: why is this an error? Why does
the commit fail in this situation instead of correcting the eols
according to the svn:eol-style property?
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest interface to (Sub)version control
/_/ \_\ http://tortoisesvn.net
Received on 2013-02-24 19:42:38 CET