Re: [RFC] Build System Documentation

On 20/02/13 21:06, Ben Reser wrote:
> On Mon, Feb 18, 2013 at 4:10 AM, Gabriela Gibson
> <gabriela.gibson_at_gmail.com> wrote:

Thank you for the corrections and ideas, they have been worked into the
document.

> Also
> typo of recognized/recognised (depending on preference US vs UK
> spelling).
What is the preferred spelling for Subversion projects? It's nicer to
stick to one or the other.

You can easily see the difference
> by running `./autogen.sh` saving the build-outputs.mk and then running
> `./autogen.sh -s` and comparing the results.

Should there be a section on how and when to run the various parts of
the build system?

> You skipped the primary function of gen-make.py which is caused by
> this call "generator.write()".

There are two gen-make.py files -- I was describing /trunk/gen-make.py.

It may be worthwhile to rename the /trunk/gen-make.py if that is possible.

I'm working on a new section to briefly describe the Python suite.

>> [libsvn_fs_base]
>
> implementation of the BDB backend.
>
>> [libsvn_fs_fs]
>
> implementation of the fsfs backend.
>
>> [libsvn_ra_local] Accessing repositories via direct libsvn_fs
>
> More accurately: Accessing repositories via direct libsvn_repos.
> Primarily this is implemented on top of libsvn_repos but some things
> end up using functions in libsvn_fs. So I wouldn't mention libsvn_fs.

PATCH idea: I took the examples from the comments in build.conf, and I
could update build.conf comments to incorporate your corrections for the
comment less entries.
Received on 2013-02-22 18:13:04 CET