Re: svn commit: r1442071 - in /subversion/trunk/subversion/libsvn_fs_fs: dag.c temp_serializer.c

On Mon, Feb 4, 2013 at 7:31 PM, Blair Zajac <blair_at_orcaware.com> wrote:

> On 02/04/2013 02:38 AM, stefan2_at_apache.org wrote:
>
>> Author: stefan2
>> Date: Mon Feb 4 10:38:45 2013
>> New Revision: 1442071
>>
>> URL: http://svn.apache.org/viewvc?**rev=1442071&view=rev<http://svn.apache.org/viewvc?rev=1442071&view=rev>
>> Log:
>> Speed up serialization of DAG and noderev structures for our caches.
>> Turns out that 503 bytes is often not sufficient for noderevs with
>> longer path names and even less so for DAG nodes. Up that to 1007
>> bytes (+1 0-terminator +16 bytes memory management overhead = 1kB).
>>
>
> What happens with paths that are longer than 1007 bytes? If two paths
> differ, say at the suffix, past that length, then will they have the same
> cache key?
>

The buffer will be auto-expanded (see docstring).
But that comes at a non-zero extra cost, so let's
avoid it in the majority of cases.

-- Stefan^2.

-- 
Certified & Supported Apache Subversion Downloads:
*
http://www.wandisco.com/subversion/download
*