Re: FSFS format7 status and first results

On Mon, Feb 18, 2013 at 1:46 PM, Daniel Shahaf <danielsh_at_elego.de> wrote:

> Stefan Fuhrmann wrote on Sat, Feb 16, 2013 at 10:52:21 +0100:
> > Hey all,
> >
> > Just to give you an update on what is going on that branch,
> > here a few facts and numbers. Bottom line is that there is
> > still a lot to do but the basic assumptions proved correct and
> > significant benefits can already be demonstrated.
>
> Thanks for the update. Sounds good. How much has the internal code
> structure changed? (apart from splitting fs_fs.c) I'm trying to get
> a handle on the maintainability / bus factor of the new code.
>

Existing code did not change very much (guess: <100 lines
touched). The "diverging" parts can be found in cached_data.c
and transaction.c. pack.c simply selects two disjoint code
paths. I find the refactoring already payed off in that there
e.g. were only a few places, all in 1 file, that I had to hook
to implement a complete data access log.

For format7, however, a lot of new / extra code kicks in and
ultimately we may see a 50 .. 100% increase in FSFS code
size. As soon as 1.8 got release, people may have spare
cycles to discuss design and review code (now that we know
format7 basically works and what should be done to make
it even better).

-- Stefan^2.

-- 
Certified & Supported Apache Subversion Downloads:
*
http://www.wandisco.com/subversion/download
*