On 20/02/13 18:54, Daniel Shahaf wrote:
> Gabriela Gibson wrote on Wed, Feb 20, 2013 at 16:22:36 +0000:
>> On 20/02/13 15:28, Gabriela Gibson wrote:
>> +++ publish/.htaccess (working copy)
>> @@ -1,7 +1,6 @@
>> # duplicated in httpd.conf in r795618
>> Options +Includes
>>
>> -XBitHack On
>> RedirectMatch ^/buildbot(.*) http://ci.apache.org/waterfall?\
>> \&show=bb-openbsd\
>> \&show=svn-slik-w2k3-x64-local\
>
> You might want to commit this part separately? It isn't as much related
> to the other changes as something we found while working on them.
True. Removed and queued.
>> +++ publish/docs/community-guide/community-guide.html (working copy)
>> @@ -73,6 +77,7 @@ first.</p>
> You seem to have added "web" before "debugging" here, while it's after
> "debugging" everywhere else.
Oops. Thanks, and well spotted!
>
>> +++ publish/docs/community-guide/web.part.html (revision 0)
>
> A couple of minor comments about this file:
>
>> +<p>Putting it all together, an example VirtualHost configuration is:</p>
>> +
>> +<pre><VirtualHost *:8080>
>> + ServerAdmin webmaster_at_localhost
>
> Consider putting this example in a separate *.conf file, to make it
> easier to reuse?
I've left it on for now, but I'm wondering if you find it too spammy
this way or it's just the convenience of the *.conf file? We can do
both, but indeed, there is a lot to be said for brevity.
>
> 'diff -u ~/projects/svn/site/**/svnsite.conf /etc/apache2/svnsite.conf'
>
>> +<p>then upload the resulting file to a HTML validatory, for
>
> "validatory"?
>
Yes :) It's an unusual but technically correct term. I've left it in
for now, because one thing about documentation is that it's a little
boring to read, and interesting wording helps people remember things
easier.
>>
>> Addition of section to Community Guide describing procedure for
>
> Use the imperative: "Add a section"
>
Fixed.
> You didn't include README in the patch.
Oops. Fixed. Forgot to 'svn add'.
> Bottom line: once the points about README and .htaccess are addressed,
Done.
> +1 to commit. (Everything else can be addressed post-commit if you
> disagree with the review.) Thanks or the patch!
>
To sum up:
1) .htaccess and permission changes will go into a separate patch.
2) With view to a further patch, the term 'Validatory' is still being
discussed, and we need to decide is the conf stays on the page and/or is
moved to it's own file, linked from this spot.
Received on 2013-02-20 22:04:00 CET