Re: [PATCH] Small fixes to the Perl bindings

On Wed, Feb 13, 2013 at 5:28 PM, Ben Reser <ben_at_reser.org> wrote:

> ... Retrieving values out of a
> svn_opt_revision_t object would have exercised the issue since you're
> calling the generated accessor function
>

Err, no. The accessor functions don't go through the typemap, only
the wrappers for "real" functions do that (add a printf() or warn() at the
start of svn_swig_pl_set_revision() to see when it's called).

So the ultimate test that the typemap does the right thing for a
_p_svn_opt_revision_t object is to pass one into a wrapped function
with a svn_opt_revision_t* parameter (on the C level). Unfortunately
any such function needs at least a repository to test.

The attached patch adds a test passing an _p_svn_opt_revision_t
into SVN::Client::log2 (ie. the wrapper for svn_client_log2).
Note that I slightly modified the svn:externals string in the existing test
case
in order to obtain _p_svn_opt_revision_t objects of kinds "head" and
"number".

Cheers, Roderich