Re: [patch] Don't discard sqlite's error code

Julian Foad wrote on Thu, Feb 14, 2013 at 21:17:03 +0000:
> Daniel Shahaf wrote:
> > @@ -739,8 +743,8 @@ init_sqlite(void *baton, apr_pool_t *pool)
> >   {
> >     int err = sqlite3_config(SQLITE_CONFIG_MULTITHREAD);
> >     if (err != SQLITE_OK && err != SQLITE_MISUSE)
> > -      return svn_error_create(SQLITE_ERROR_CODE(err), NULL,
> > -                              _("Could not configure SQLite"));
> > +      return svn_error_createf(SQLITE_ERROR_CODE(err), NULL,
> > +                              _("Could not configure SQLite (%d)"),
> > err);
>
> In cases like this one, it seems we should be using one of the above sqlite -> svn error converters so that we get the full SQLite description, and then wrapping the resulting svn error object with "Could not configure SQLite".
>

As in:

      return svn_error_quick_wrap(svn_error_create(SQLITE_ERROR_CODE(err), NULL, NULL)
                                 _("Could not configure SQLite (%d)"));

?

> - Julian
Received on 2013-02-14 22:20:39 CET