Re: [PATCH] Small fixes to the Perl bindings

On Tue, Feb 12, 2013 at 6:06 PM, Ben Reser <ben_at_reser.org> wrote:

> FYI you may want to apply the changes in r1445267 to your local copy.
> I found a bug in the conversion of the svn_opt_revision_t typemap to
> use a function.
>

Ouch. Your diagnosis is correct, though I can't reproduce your symptoms :)
The previously failing tests in t/9wc.t do not cover the problematic
conversion.
For that, you would have to pass a Perl _svn_opt_opt_revision_t object
(e.g. obtained from the return value of
SVN::Wc::parse_externals_description3)
into a wrapped function expecting a C *svn_opt_revision_t, e.g.
SVN::Client::log.

Anyway, the pointer to pointer thing is ugly. What about the following patch
that makes it more explicit that the converted argument may be assigned to?

Cheers, Roderich