Re: [PATCH] Re: [PATCH] OPW 2013: Build System Gtest Addition

On 12.02.2013 18:36, Stefan Sperling wrote:
> On Wed, Feb 06, 2013 at 08:37:04AM +0000, Gabriela Gibson wrote:
>> On 05/02/13 17:00, Branko Čibej wrote:
>>> On 05.02.2013 14:28, Gabriela Gibson wrote:
>>> I'm almost sure you meant, "path = gtestlib".
>>>
>>> -- Brane
>>>
>> Nope, meant libgtest, ended up with both and the mistake compiled %-)
>>
>> I think it's working now, see attached patch.
> Branko, any news?

Fighting viruses (the biological kind), so I haven't tested the patch yet.

> This patch only seems to support a build with an in-tree libgtest
> obtained with get-deps.sh. Will there be support for using a system-wide
> gtest installation, too? Or does that not make sense?

It does not make sense, no. libgtest has to be built from source with
the same compiler and flags as the rest of the C++ code being tested.
While Ubuntu for example has a package that installs the sources in
/usr/src, I think it's OK for now to not worry about alternate source
locations.

> Gabriela, feel free to commit this patch to your branch, and then
> commit further follow-up fixes there, too, if any.

+1

-- Brane

-- 
Branko Čibej
Director of Subversion | WANdisco | www.wandisco.com