[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn blame not working for files which had binary mime-type in a previous revision

From: Bert Huijben <bert_at_qqmail.nl>
Date: Tue, 12 Feb 2013 21:25:09 +0100

> -----Original Message-----
> From: MARTIN PHILIP [mailto:codematters_at_ntlworld.com] On Behalf Of
> Philip Martin
> Sent: dinsdag 12 februari 2013 19:30
> To: Bert Huijben
> Cc: Ferenc Kovacs; dev_at_subversion.apache.org
> Subject: Re: svn blame not working for files which had binary mime-type in a
> previous revision
>
> I'm still not clear what would go wrong.

From an earlier mail (copied from below):
>> Suppose I have a file that really was binary in the past, perhaps a
>> shell script that used to be an ELF binary. When blame reaches the
>> binary revision the binary data is likely to get treated as one or more
>> lines of text, none of which match the current text. At that point the
>> blame algorithm is complete. Isn't that the right answer?

This assumes that we blame backwards, while we really run blame forwards.

For many cases running it backwards would be more efficient (e.g. you could just ask for the lines in the last 100 changed revisions)... Or in your own code stop when one specific interesting line gets changed and cancel the incoming data.

But that requires extending the api that is below the svn_ra_file_revisions() api to allow passing a reversed range.

        Bert
Received on 2013-02-12 21:25:54 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.