Re: [PATCH] Don't break 'make install-tools' if TOOLSDIR is same as BINDIR.

Alexander Thomas wrote:
> This originated from one of my requirement where svn* binaries and tools need to
> be installed in same location.
> I'm not sure this one qualifies as a valid patch, because for this to happen
> someone should tweaks Makefile.in
> and points $bindir and $toolsdir to same location.

I think this is fine and we should apply it.  I'm having trouble testing it at the moment because 'make install-tools' is failing for me at an earlier stage, but the patch looks fine as far as I can see.

- Julian

> [[[
> Don't break 'make install-tools' if TOOLSDIR is same as BINDIR.
>
> * Makefile.in
>   (INSTALL_EXTRA_TOOLS): Check that target and link_name are not the
>    same before creating symlink to svnmucc in BINDIR.
>
> Patch by: Alexander Thomas <alexander{_AT_}collab.net>
> ]]]

(For quick reference, the patch is basically this, in Makefile.in:)
+ if test "$(DESTDIR)$(bindir)" != "$(DESTDIR)$(toolsdir)"; then \
    ln -sf $(DESTDIR)$(bindir)/svnmucc$(EXEEXT) $(DESTDIR)$(toolsdir)/svnmucc$(EXEEXT); \
+ fi
Received on 2013-02-11 14:54:31 CET