On Thu, Jan 31, 2013 at 4:43 AM, roderich.schupp_at_gmail.com
<roderich.schupp_at_gmail.com> wrote:
> while trying to use svn_wc_parse_externals_description3 from Perl I
> stumbled over a fex things.
> Patches below are against trunk.
First of all thanks for the patches.
> perl-bindings-1.patch
>
> [[[
> Make svn_wc_parse_externals_description3 available from Perl bindings.
>
> * subversion/bindings/swig/include/svn_containers.swg:
> Add output typemap for APR array of svn_wc_external_item2_t.
>
> * subversion/bindings/swig/perl/native/Wc.pm:
> Document function svn_wc_parse_externals_description3.
> Add the magic to access struct svn_wc_external_item2_t
> as an object and document its methods.
>
> * subversion/bindings/swig/perl/native/Core.pm:
> Fix a typo that prevented the use of
> _p_svn_opt_revision_value_t objects.
> ]]]
Applied unmodified in r1443783.
For future reference though if you're adding support for a function
it'd be nice to add tests for it. I added some tests in r1443788. I
realize there's a lot of things that aren't tested in there now.
But if you provide tests it'll speed my ability to apply it since I
don't have to write them before I can apply your changes.
> perl-bindings-2.patch
>
> [[[
> Replace inline typemap with a function.
>
> * subversion/bindings/swig/include/svn_types.swg:
> The bulky input typemap for svn_opt_revision_t is inlined
> by Swig for each use in the generated Perl bindings.
> Move its body ...
>
> * subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.c
> (svn_swig_pl_set_revision): ... to a new function here.
>
> * subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.h:
> Add function prototype.
> ]]]
Committed in r1443811 with a fix to the croak on the missing closing
brace not having the input arg for the %s in the format string. Also
adjusted the commit message to mention the improvement of the error
messages.
Wish I could write tests for this but I can't because we croak. But
that's a long standing problem.
> perl-bindings-3.patch
>
> [[[
> Documentation fix for SVN::Ra.
>
> * subversion/bindings/swig/perl/native/Ra.pm
> Fix examples: the $path parameter for SVN::Ra::get_dir() and
> SVN::Ra::get_file() must not start with a slash.
> ]]]
Applied unmodified in r1443813.
Received on 2013-02-08 01:53:43 CET