Re: Coniguring 301/302 redirects to track an fspath rename

On 02/05/2013 05:26 PM, Bert Huijben wrote:
> Looking at this stack, this error originates in the iprops fetch that was
> added before the actual update for 1.8.

Here's the immediate fix for the NULL location:

{{{
Index: subversion/libsvn_ra_serf/property.c
===================================================================
--- subversion/libsvn_ra_serf/property.c (revision 1442766)
+++ subversion/libsvn_ra_serf/property.c (working copy)
@@ -637,7 +637,7 @@

   err2 = svn_ra_serf__error_on_status(handler->sline.code,
                                       handler->path,
- NULL);
+ handler->location);
   if (err2)
     {
       svn_error_clear(err);
}}}

I haven't time to give a full test run right now -- heading out the door for
a meeting.

But there's another problem here anyway, which is that
response_get_location() in libsvn_ra_serf/util.c is only return the path
portion of the URL provided by the server. Not sure precisely when that
started happening -- r1351138 seems key here -- but either way, we
absolutely need the full (canonicalized-for-Subversion-use) URL here to
continue properly handling redirects which point to a different server.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Enterprise Cloud Development