[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1442555 - /subversion/trunk/subversion/libsvn_repos/reporter.c

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Tue, 5 Feb 2013 10:20:28 -0500

On 02/05/2013 06:55 AM, ivan_at_apache.org wrote:
> Author: ivan
> Date: Tue Feb 5 11:55:17 2013
> New Revision: 1442555

[...]

> +++ subversion/trunk/subversion/libsvn_repos/reporter.c Tue Feb 5 11:55:17 2013

[...]

> + /* Is this delta calculation worth our time? We'll do everything we can
> + to avoid transmitting even an empty text-delta in that case.
> + It doesn't matter if we are ignoring ancestry or not: we're not
> + interested in theoretical differences between "has contents which
> + have not changed with respect to" and "has the same actual contents
> + as" when sending text-delta. */

You've left this comment somewhat crippled. Suggest simplifying:

     /* We're not interested in the theoretical difference between "has
        contents which have not changed with respect to" and "has the same
        actual contents as" when sending text-deltas. If we know the
        delta is an empty one, we avoiding sending it in either case. */

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Enterprise Cloud Development

Received on 2013-02-05 16:21:03 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.