On Tue, Feb 5, 2013 at 3:41 PM, Bert Huijben <bert_at_qqmail.nl> wrote:
>
>
>> -----Original Message-----
>> From: stefan2_at_apache.org [mailto:stefan2_at_apache.org]
>> Sent: dinsdag 5 februari 2013 10:37
>> To: commits_at_subversion.apache.org
>> Subject: svn commit: r1442518 - in /subversion/branches/fsfs-
>> format7/subversion/libsvn_fs_fs: low_level.c low_level.h
>>
>> Author: stefan2
>> Date: Tue Feb 5 09:37:02 2013
>> New Revision: 1442518
>>
>> URL: http://svn.apache.org/viewvc?rev=1442518&view=rev
>> Log:
>> On the fsfs-format7 branch: extend the representation header
>> data structure to contain the offset between representation start
>> and actual begin of the plain or deltified data (= header size).
>
>> Modified: subversion/branches/fsfs-
>> format7/subversion/libsvn_fs_fs/low_level.h
>> URL: http://svn.apache.org/viewvc/subversion/branches/fsfs-
>> format7/subversion/libsvn_fs_fs/low_level.h?rev=1442518&r1=1442517&r2
>> =1442518&view=diff
>> ==========================================================
>> ====================
>> --- subversion/branches/fsfs-format7/subversion/libsvn_fs_fs/low_level.h
>> (original)
>> +++ subversion/branches/fsfs-format7/subversion/libsvn_fs_fs/low_level.h
>> Tue Feb 5 09:37:02 2013
>> @@ -113,6 +113,11 @@ typedef struct svn_fs_fs__rep_header_t
>> /* if this rep is a delta against some other rep, this is the (deltified)
>> * size of that base rep. Should be 0 if there is no base rep. */
>> svn_filesize_t base_length;
>> +
>> + /* length of the textual representation of the header in the rep or pack
>> + * file, including EOL. Only valid after reading it from disk.
>> + * Should be 0 otherwise. */
>> + apr_size_t header_size;
>> } svn_fs_fs__rep_header_t;
>
> Are you sure you want an architecture dependent size in this struct?
>
> I would expect an explicit 32 or 64 bit int here.
>
+1!
--
Ivan Zhakov
Received on 2013-02-05 12:56:38 CET