[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] implement keywords substitution in mod_dav_svn

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Mon, 4 Feb 2013 09:55:05 -0500

On 02/04/2013 06:30 AM, Philip Martin wrote:
> jinfroster <jinfroster_at_mail.ru> writes:
>
>> Add "SVNKeywordSubstitution" per-directory (repository) mod_dav_svn
>> configuration parameter (default is "Off"). Implement keywords
>> substitution.
>
>> * subversion/mod_dav_svn/repos.c
>> (set_headers):
>> If parameter SVNKeywordSubstitution is On, don't send
>> "Content-length". We can't guess the size of expanded stream at
>> the moment (..is that bad?)
>> (deliver):
>> If parameter SVNKeywordSubstitution is On, perform keywords
>> substitution, like client-side utilities do.
>
> Does your Subversion client use neon? I think this causes the server to
> send expanded keywords in response to GET requests and so will break
> Subversion clients using serf.

Yes, that's precisely what it does. But the problem isn't limited to Serf
clients. Any call to svn_ra_get_file() -- for example, to support 'svn cat'
-- will suffer. So, yeah, cool idea, but unfortunately the patch is
unacceptable as-is.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Enterprise Cloud Development

Received on 2013-02-04 15:55:50 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.