RE: svn commit: r1441814 - in /subversion/trunk/subversion: svn/

From: Bert Huijben <bert_at_vmoo.com>
Date: Sun, 3 Feb 2013 01:41:29 -0800

tests/cmdline/
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary=047d7b66f6c3db7dab04d4cd9e91

--047d7b66f6c3db7dab04d4cd9e91
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Maybe we should try to fix this automatic detection then (Does your
setting match the libmagic output for that file?) instead of adding
just a warning when setting the file binary explicitly.

Maybe we should validate our libmagic based decision to make something
binary?

Bert Huijben (Cell phone)
From: Justin Erenkrantz
Sent: 3-2-2013 9:18
To: Bert Huijben
Cc: dev_at_subversion.apache.org
Subject: Re: svn commit: r1441814 - in /subversion/trunk/subversion:
svn/ tests/cmdline/
As another data point, I have hit this text-as-binary myself just a few
weeks ago when I added a bunch of HTML files to a local repository - so,
it's definitely occurring automatically. I did not have a chance to dig
into why the magic detection failed so miserably... -- justin

On Saturday, February 2, 2013, Bert Huijben wrote:

>
>
> > -----Original Message-----
> > From: stsp_at_apache.org <javascript:;> [mailto:stsp_at_apache.org<javascript=
:;>
> ]
> > Sent: zaterdag 2 februari 2013 23:05
> > To: commits_at_subversion.apache.org <javascript:;>
> > Subject: svn commit: r1441814 - in /subversion/trunk/subversion: svn/
> > tests/cmdline/
> >
> > Author: stsp
> > Date: Sat Feb 2 22:04:44 2013
> > New Revision: 1441814
> >
> > URL: http://svn.apache.org/viewvc?rev=3D1441814&view=3Drev
> > Log:
> > When a binary mime-type is set on a file that looks like a text file,
> > make the 'svn' client print a warning about potential future problems
> > with operations such as diff, merge, and blame.
> >
> > This is only done during local propset for now, because the file needs
> > to be present on disk to detect its mime-type.
> >
> > See for related discussion: http://mail-
> > archives.apache.org/mod_mbox/subversion-
> > dev/201301.mbox/%3C20130131185725.GA13721%40ted.stsp.name%3E
>
> From my users I hear that another way this property is introduced is via
> conversions from other version management systems. Visual SourceSafe (lon=
g
> dead, but still used in a lot of small shops) marks UTF-8 files with a BO=
M
> as binary when it does an auto detect.
> (Well what would you guess for a system that wasn=E2=80=99t really update=
d since
> that format became popular)
>
> Most conversion tools just copy the binary flag, and there you have this
> problem on all your historic utf-8 files.
> (Where I worked we had this problem on all .xml files previously stored i=
n
> sourcesafe).
>
>
> I don't see a lot of users accidentally adding invalid properties
> themselves.
>
> Bert
>
>

--047d7b66f6c3db7dab04d4cd9e91
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

<html><head><meta content=3D"text/html; charset=3Dutf-8" http-equiv=3D"Cont=
ent-Type"></head><body><div><div style=3D"font-family: Calibri,sans-serif; =
font-size: 11pt;">Maybe we should try to fix this automatic detection then =
(Does your setting match the libmagic output for that file?) instead of add=
ing just a warning when setting the file binary explicitly. Maybe we=
should validate our libmagic based decision to make something binary? =
 Bert Huijben (Cell phone) </div></div><hr>From: <spa=
n style=3D"font-family: Tahoma,sans-serif; font-size: 10pt;">Justin Erenkra=
ntz Sent: 3-2-2013 9:18 To: <span=
style=3D"font-family: Tahoma,sans-serif; font-size: 10pt;">Bert Huijben</s=
pan> Cc: dev_at_subversion.apache.org Subject: </s=
pan>Re: sv=
n commit: r1441814 - in /subversion/trunk/subversion: svn/ tests/cmdline/</=
span> </body></html>As another=C2=A0data point, I have =
hit this text-as-binary myself just a few weeks ago when I added a bunch of=
HTML files to a local repository -=C2=A0so, it's definitely occurring =
automatically. =C2=A0I did not have a chance to=C2=A0dig into why the magic=
detection failed so miserably...=C2=A0 -- justin 
 On Saturday, February 2, 2013, Bert Huijben wrote: <blockquote clas=
s=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;pad=
ding-left:1ex"> 
 
> -----Original Message----- 
> From: <a href=3D"javascript:;" onclick=3D"_e(event, 'cvml', &#=
39;stsp_at_apache.org')">stsp_at_apache.org</a> [mailto:<a href=3D"javascript=
:;" onclick=3D"_e(event, 'cvml', 'stsp_at_apache.org')">stsp_at_a=
pache.org</a>]

> Sent: zaterdag 2 februari 2013 23:05 
> To: <a href=3D"javascript:;" onclick=3D"_e(event, 'cvml', &#39=
;commits_at_subversion.apache.org')">commits_at_subversion.apache.org</a> 
> Subject: svn commit: r1441814 - in /subversion/trunk/subversion: svn/<=
br>
> tests/cmdline/ 
> 
> Author: stsp 
> Date: Sat Feb =C2=A02 22:04:44 2013 
> New Revision: 1441814 
> 
> URL: <a href=3D"http://svn.apache.org/viewvc?rev=3D1441814&view=3D=
rev" target=3D"_blank">http://svn.apache.org/viewvc?rev=3D1441814&view=
=3Drev</a> 
> Log: 
> When a binary mime-type is set on a file that looks like a text file,<=
br>
> make the 'svn' client print a warning about potential future p=
roblems 
> with operations such as diff, merge, and blame. 
> 
> This is only done during local propset for now, because the file needs=
 
> to be present on disk to detect its mime-type. 
> 
> See for related discussion: <a href=3D"http://mail-" target=3D"_blank"=
>http://mail-</a> 
> <a href=3D"http://archives.apache.org/mod_mbox/subversion-" target=3D"=
_blank">archives.apache.org/mod_mbox/subversion-</a> 
> dev/201301.mbox/%3C20130131185725.GA13721%<a href=3D"http://40ted.stsp=
.name" target=3D"_blank">40ted.stsp.name</a>%3E 
 
From my users I hear that another way this property is introduced is via co=
nversions from other version management systems. Visual SourceSafe (long de=
ad, but still used in a lot of small shops) marks UTF-8 files with a BOM as=
binary when it does an auto detect.

(Well what would you guess for a system that wasn=E2=80=99t really updated =
since that format became popular) 
 
Most conversion tools just copy the binary flag, and there you have this pr=
oblem on all your historic utf-8 files. 
(Where I worked we had this problem on all .xml files previously stored in =
sourcesafe). 
 
 
I don't see a lot of users accidentally adding invalid properties thems=
elves. 
 
=C2=A0 =C2=A0 =C2=A0 =C2=A0 Bert 
 
</blockquote>

--047d7b66f6c3db7dab04d4cd9e91--
Received on 2013-02-03 10:42:04 CET

This message: [ Message body ]
Next message: Justin Erenkrantz: "Re: svn commit: r1441814 - in /subversion/trunk/subversion: svn/"
Previous message: Justin Erenkrantz: "Re: svn commit: r1441814 - in /subversion/trunk/subversion: svn/ tests/cmdline/"
Next in thread: Justin Erenkrantz: "Re: svn commit: r1441814 - in /subversion/trunk/subversion: svn/"
Reply: Justin Erenkrantz: "Re: svn commit: r1441814 - in /subversion/trunk/subversion: svn/"

Contemporary messages sorted: [ by date ] [ by thread ] [ by subject ] [ by author ] [ by messages with attachments ]