RE: Unsafe WC DB calls: sqlite_column_text(..., pool=NULL)

> -----Original Message-----
> From: Julian Foad [mailto:julianfoad_at_btopenworld.com]
> Sent: dinsdag 29 januari 2013 17:15
> To: Subversion Development
> Subject: Unsafe WC DB calls: sqlite_column_text(..., pool=NULL)
>
> I noticed code like this in wc_db.c:
>
>   const char *relpath = svn_sqlite__column_text(stmt, 0, NULL);
>   svn_kind_t kind = svn_sqlite__column_token(stmt, 1, kind_map);
>
>
> According to the docs [1], the second _column_*() call can overwrite the
> value returned by the first one, since we passed NULL as the 'result_pool'
> argument.

Then we should fix our docs.

It is safe until you go to the next row.

        Bert
Received on 2013-01-29 18:35:44 CET