[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] minor change to mailer.py for subject formatting

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Mon, 28 Jan 2013 19:29:49 +0200

Ben Reser wrote on Mon, Jan 28, 2013 at 09:25:30 -0800:
> On Mon, Jan 28, 2013 at 5:59 AM, C. Michael Pilato <cmpilato_at_collab.net> wrote:
> > My only remaining minor nit is the variable name itself. First, other
> > variable names in this script use underscores to separate words: for_repos,
> > label_from, etc. Secondly, it's really only the basename of the directory
> > that's being substituted in, and I think the variable name should carry that
> > information. (I had to read your docs to make sure I wouldn't wind up with
> > "[svn-/path/to/my/repository commit]".) So, I'd suggest using
> > "repos_basename" rather than "repodir". Again, it's a minor thing -- and
> > one that the patch applier can probably make on your behalf -- but if the
> > name caused me some initial confusion, it'll probably do the same to someone
> > else, too.
> I almost said something about the name too when I reviewed it. I let
> it go since you could easily say repodir means the name of the
> directory that the repo is in. I'd have gone with repos_name
> personally.
> But at this point I feel like we're painting the bikeshed.

I'll commit with cmpilato's tweaks (indentation and varname) as I agree
with them both.
Received on 2013-01-28 18:30:28 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.