[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Support regex in EXPECTED ERR list

From: Prabhu Gnana Sundar <prabhugs_at_collab.net>
Date: Mon, 28 Jan 2013 12:51:40 +0530

On 01/25/2013 01:47 PM, Ben Reser wrote:
> To add some clarity here to what I'm saying above...
> There are two options.
> 1) Build a new class (could be named RegexListOutput) like I mention
> above or in an earlier email. This will likely be a tad easier, since
> you don't change the logic existing tests are using and thus you don't
> have to do do negative testing against all the tests (which is
> probably a lot) that use the existing classes.
> 2) Adjust RegexOutput so that it can handle more than one Regex. It's
> already expecting a list, it just ignores everything but the first
> member. This is probably the cleaner approach but you need to at a
> minimum go through and check every use of RegexOutput to make sure it
> isn't passing multiple regexes and consider what the impact is.
> You'll also need to be very careful not to change the logic the
> existing users of RegexOutput depend on.

Thanks a lot Ben...

I have taken your suggestion (2) and worked on it.
Attaching the updated patch and the log message. Please share your thoughts.

Thanks and regards

Received on 2013-01-28 08:22:47 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.