[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] minor change to mailer.py for subject formatting

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Sat, 26 Jan 2013 23:36:22 -0500

On 01/26/2013 03:03 PM, Daniel Shahaf wrote:
> Please attach patches as MIME text/plain (usually naming them *.txt does
> that). More below.
>> + if prefix and re.search(r'REPONAME', prefix):
> Needlessly complicated, ('REPONAME' in prefix) would do.
> Also I think you should use the %() syntax like mailer.conf.example
> does. Is that possible?

Agreed, please use the "%()s" style of format string substitution if
possible (for consistency with other configurable bits of this script).

C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Enterprise Cloud Development

Received on 2013-01-27 05:37:02 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.