[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1437354 - /subversion/trunk/subversion/tests/svn_test_fs.c

From: Ivan Zhakov <ivan_at_visualsvn.com>
Date: Wed, 23 Jan 2013 18:43:15 +0400

On Wed, Jan 23, 2013 at 4:42 PM, Philip Martin
<philip.martin_at_wandisco.com> wrote:
>> Log:
>> When removing old repositories before re-creating them for tests, we don't
>> need to be clean about it, so just recursively remove the directory.
>>
>> * subversion/tests/svn_test_fs.c
>> (svn_test__create_repos): Just remove the target directory, rather than
>> just the repository.
>>
[.. ]
>> if (finfo.filetype == APR_DIR)
>> - SVN_ERR(svn_repos_delete(name, pool));
>> + SVN_ERR_W(svn_io_remove_dir2(name, TRUE, NULL, NULL, pool),
>> + apr_psprintf(pool,
>> + "cannot create repos '%s' there is already "
>> + "a directory of that name", name));
>> else
>> return svn_error_createf(SVN_ERR_TEST_FAILED, NULL,
>> "there is already a file named '%s'", name);
>>
>>
>
> That was the only call to svn_repos_delete in the testsuite. We should
> have a proper regression test.
>
Done in r1437414.

-- 
Ivan Zhakov
Received on 2013-01-23 15:44:08 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.