[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] OPW 2013: Build System Gtest Addition

From: Stefan Sperling <stsp_at_elego.de>
Date: Tue, 22 Jan 2013 13:03:06 +0100

On Tue, Jan 22, 2013 at 11:15:30AM +0000, Gabriela Gibson wrote:
> Part of my 2013 OPW Project for Subversion is to add the Googletest
> test suite to be compiled by the build system.
> Googletests's pages can be found here:
> http://code.google.com/p/googletest/
> There are 3 attachments: the patch, the log and a screen capture of
> the build system output.

This is looking very promising!

> Known problems:
> 1. Currently there is no option provided to make compilation of Gtest
> optional. The code in /trunk/build/ac-macros/gtest.m4 suggests that
> there should be provision for this, but I could not get it to work.

I think gtest should be an optional build dependency on trunk.
Else, it would disrupt other developer's environments and the buildbots.
So committing this to trunk as it is would not be a very good idea.

I think this is a good opportunity to offer you partial commit access
to Subversion so you can work on this on a branch. Then you can commit
the patch there and keep making improvements. Once it is ready for trunk
we can merge the branch back.
(See http://subversion.apache.org/docs/community-guide/roles.html#partial-commit-access)

I'll send you private email about this shortly!
Received on 2013-01-22 13:03:50 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.