[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r1435746 - in /subversion/trunk/subversion: include/ libsvn_fs/ libsvn_fs_base/ libsvn_fs_fs/ libsvn_repos/ svnadmin/

From: Bert Huijben <bert_at_qqmail.nl>
Date: Mon, 21 Jan 2013 12:46:35 +0100

> -----Original Message-----
> From: stefan2_at_apache.org [mailto:stefan2_at_apache.org]
> Sent: zaterdag 19 januari 2013 23:45
> To: commits_at_subversion.apache.org
> Subject: svn commit: r1435746 - in /subversion/trunk/subversion: include/
> libsvn_fs/ libsvn_fs_base/ libsvn_fs_fs/ libsvn_repos/ svnadmin/
>
> Author: stefan2
> Date: Sat Jan 19 22:45:02 2013
> New Revision: 1435746
>
> URL: http://svn.apache.org/viewvc?rev=1435746&view=rev
> Log:
> Fix issues #3995 (redesign svn_fs_verify() for 1.8) and #4211 (verify
> is slow and needs to handle node verification better).
>
> This patch does two things. First, it adds a notification callback
> to svn_fs_verify() and forwards its output to our console stream.
>
> The second change is that revision-specific checks are begin moved
> from svn_fs_fs__verify() to a new svn_fs_verify_rev() function.
> Because the latter is being called as part of the per-revision checks,
> progress is visible and access / cache locality is very much improved.

I'm not exactly sure which of the patches is responsible but currently running the BDB tests produces:
[[[
W: Error while running 'svnadmin verify'.
W: EXPECTED STDERR:
* Verifying global structure ...
* Verified revision 0.
* Verified revision 1.
* Verified revision 2.
W: ACTUAL STDERR:
* Verified revision 0.
* Verified revision 1.
* Verified revision 2.
W: DIFF STDERR:
--- EXPECTED STDERR
+++ ACTUAL STDERR
@@ -1,4 +1,3 @@
-* Verifying global structure ...
 * Verified revision 0.
 * Verified revision 1.
 * Verified revision 2.
W: CWD: /home/buildslave16/slave16/bb-openbsd/build/subversion/tests/cmdline
W: EXCEPTION: SVNLineUnequal
Traceback (most recent call last):
  File "/home/buildslave16/slave16/bb-openbsd/svn-trunk/subversion/tests/cmdline/svntest/main.py", line 1424, in run
    rc = self.pred.run(sandbox)
  File "/home/buildslave16/slave16/bb-openbsd/svn-trunk/subversion/tests/cmdline/svntest/testcase.py", line 176, in run
    return self.func(sandbox)
  File "/home/buildslave16/slave16/bb-openbsd/svn-trunk/subversion/tests/cmdline/svnadmin_tests.py", line 562, in verify_windows_paths_in_repos
    "* Verified revision 2.\n"], errput)
  File "/home/buildslave16/slave16/bb-openbsd/svn-trunk/subversion/tests/cmdline/svntest/verify.py", line 369, in compare_and_display_lines
    raise raisable
SVNLineUnequal
FAIL: svnadmin_tests.py 11: verify a repository containing paths like 'c:hi'
]]]

I think the test verification needs a bit of relaxation.

        Bert
Received on 2013-01-21 12:47:14 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.