[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1432778 - in /subversion/trunk/tools/server-side/svnpubsub: README.txt commit-hook.py daemonize.py example.conf irkerbridge.py notes/ svnpubsub/client.py svnpubsub/server.py svnwcsub.conf.example svnwcsub.py test.conf testserver.py watcher.py

From: Ben Reser <ben_at_reser.org>
Date: Mon, 14 Jan 2013 09:55:35 -0800

On Sun, Jan 13, 2013 at 11:22 PM, Greg Stein <gstein_at_gmail.com> wrote:
> -1
> What the hell? The XML feature is used by the ASF.
> Why do you feel you can unilaterally remove features like this? Or create
> such incompatible changes in a system that is/has already been deployed?
> Ridiculous.
> Unhappy,
> -g

This change came out of a discussion that Daniel and I had on
#asfinfra. There had been a request for a gitsubpub. We ended up
talking about what changes we should make to the protocol in order to
generalize it more.

XML had been problematic because we were having to encode the data
before we put it in XML and then decode it when we took it out. The
XML generator was more than happy to generate XML that was invalid.
E.G. say someone included an illegal in XML character in their log
message. It also seemed to be a long term pain to support two formats
when one would do.

Considering that this hadn't been released yet and that the users of
it within ASF were still fairly limited we felt now was the time to
make changes.

I should have sent an email to the dev list explaining the outcome of
our discussion and the plan. I'm sorry.

Daniel is handling a coordinated upgrade. Most of the ASF tools have
been changed in the same commit. Anyone that is using the client
should have some trivial changes to get their application back
- Change to passing URLs in.
- Change the URLs they were using to match the new format.
- Change the arguments on their callback.
- Deal with name changes in the field names and with dirs_changed
being removed if they used it.

The one tool I haven't deal with is svntweet which based on the status
of @asfcommits does not seem to be in use anymore. I plan to clean it
up and make it use the client.
Received on 2013-01-14 18:56:11 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.