Re: [PATCH] Implement svnadmin verify --keep-going

Stefan Sperling wrote:

> Prabhu, any news on this? I would like to see this feature committed.
> Is there anything I could do to help move it along?
>
> Julian, do you think Prabhu's latest patch is ready for commit,
> provided Prabhu or I take care of any unaddressed concerns in
> follow-up patches? Or would committing it to trunk in its current
> state be too disruptive? If that is the case, perhaps we should
> offer Prabhu commit access to a branch where he could work on this
> feature more comfortably until it has been completed and is ready
> to be reintegrated into trunk?

What holds me back from committing it is lack of a test that at least exercises the 'keep-going' functionality (that is, reports on another revision after reporting a failed revision) and lack of evidence that it has been tested and found to work as expected in a few different failure scenarios.  I tried some quick tests by hand with a previous version of the patch and found some wrong behaviour, and haven't tested the latest version at all.  Mainly I am unwilling to commit myself to ensuring that necessary testing and follow-ups do in fact happen.

The other issues I raised are not blockers for me and could be addressed in follow-up commits.  I wouldn't veto you or anyone else committing it in its current state with follow-ups afterwards.

Prabhu is welcome to work on this on a branch from my point of view, if that would help.

Prabhu, you might also find it helpful to ask for help if you're having difficulty with some part.  For example, if you find it hard to write tests for it, it's quite possible that someone here would be willing to help or even do that for you.  (In fact it's good engineering practice for someone else to write the tests.)  Don't be shy of asking.

- Julian
Received on 2013-01-14 17:58:37 CET