[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1427278 - in /subversion/trunk/subversion: libsvn_diff/diff_file.c tests/libsvn_diff/diff-diff3-test.c

From: Johan Corveleyn <jcorvel_at_gmail.com>
Date: Fri, 11 Jan 2013 01:19:54 +0100

On Tue, Jan 1, 2013 at 3:03 AM, <rhuijben_at_apache.org> wrote:
> Author: rhuijben
> Date: Tue Jan 1 02:03:35 2013
> New Revision: 1427278
>
> URL: http://svn.apache.org/viewvc?rev=1427278&view=rev
> Log:
> Resolve another issue in the diff code when using full whitespace
> normalization.
>
> Patch by: Hideki IWAMOTO <hideki.iwamoto{_AT_}gaia.eonet.ne.jp>
> (issue confirmed and patch tweaked by me)

Bert, thanks for committing this (and thanks for another great patch, Hideki).

Could it be that you forgot to reply to Hideki that this patch was
committed? Maybe I missed something (those mailthreads during the
holidays are a bit fuzzy ...), but I didn't see a reply to his post
with this patch [1]. Unless maybe you contacted him through IRC or
something...

BTW: isn't this another good candidate for backport to 1.7? It has my
vote already :-).

[1] http://svn.haxx.se/dev/archive-2012-12/0556.shtml

-- 
Johan
Received on 2013-01-11 01:20:45 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.