Re: svn commit: r1431279 - /subversion/trunk/subversion/libsvn_wc/wc_db_util.c

Julian Foad <julianfoad_at_btopenworld.com> writes:

> Philip Martin wrote:
>
>> URL: http://svn.apache.org/viewvc?rev=1431279&view=rev
>
>> Log:
>> Ensure wc.db has the permissions allowed by umask.
>
> ... in order to be consistent with the other files we write,
> and to fix sharing a WC?
>
> If this bug was breaking sharing a WC, should we back-port this fix?

Probably.

> If we consider this to be a fix for the way SQLite behaves, do we want
> the same throughout Subversion?  Move the fix into
> svn_sqlite__open()?

The WC layer has a clear distinction between create and open so fixing
in the WC layer only adds an overhead to checkout, the other operations
are unaffected. The other user is FSFS and it does not have this
distinction so the overhead would apply to all operations. I admit the
overhead is small.

-- 
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download