[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1431072 - in /subversion/trunk/subversion: include/svn_types.h libsvn_client/copy.c libsvn_ra_serf/commit.c libsvn_subr/named_atomic.c libsvn_subr/stream.c mod_dav_svn/reports/replay.c svnadmin/svnadmin.c tests/libsvn_subr/mergeinfo-test.c

From: Blair Zajac <blair_at_orcaware.com>
Date: Wed, 09 Jan 2013 14:29:03 -0800

On 01/09/2013 01:02 PM, julianfoad_at_apache.org wrote:
> Author: julianfoad
> Date: Wed Jan 9 21:02:33 2013
> New Revision: 1431072
>
> URL: http://svn.apache.org/viewvc?rev=1431072&view=rev
> Log:
> Consistify a few remaining redundant or odd expressions involving boolean
> constants, such as "foo == FALSE" to "!foo" and "number ? FALSE : TRUE" to
> "number != 0". A follow-up to r1431017 and r1431040.

The commit is good and so is the comment on replay.c, but this should
read "number ? TRUE : FALSE" to be correct and match the code.

Blair
Received on 2013-01-09 23:29:39 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.