[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1430975 - /subversion/branches/fsfs-format7/subversion/libsvn_fs_fs/low_level.c

From: Branko Čibej <brane_at_wandisco.com>
Date: Wed, 09 Jan 2013 19:42:01 +0100

On 09.01.2013 19:35, Ben Reser wrote:
> On Wed, Jan 9, 2013 at 10:00 AM, Branko Čibej <brane_at_wandisco.com> wrote:
>> On 09.01.2013 18:54, stefan2_at_apache.org wrote:
>>> - if (header->is_delta)
>>> + if (header->is_delta == FALSE)
>> Can we please use logical operators to test boolean values, not
>> arithmetic ones?
>>
>> if (!header->is_delta)
> There's quite a few examples of this in the code right now that we
> should fix then

Agreed -- we should fix them.

-- Brane

-- 
Branko Čibej
Director of Subversion | WANdisco | www.wandisco.com
Received on 2013-01-09 19:49:17 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.