[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Regarding issue #3348 ("Provide syntax which means 'include all files *not* in a changelist'")

From: Bert Huijben <bert_at_qqmail.nl>
Date: Sat, 5 Jan 2013 00:51:28 +0100

> -----Original Message-----
> From: C. Michael Pilato [mailto:cmpilato_at_collab.net]
> Sent: vrijdag 4 januari 2013 23:30
> To: Julian Foad
> Cc: Daniel Shahaf; Subversion Development
> Subject: Re: Regarding issue #3348 ("Provide syntax which means 'include all
> files *not* in a changelist'")
> On 01/04/2013 05:10 PM, Julian Foad wrote:
> > On the other hand it does have some uses ("show me all the local mods
> > that I haven't assigned to any changelist", "assign them all to a named
> > changelist now"), and I consider the whole changelists feature to be a
> > very marginal bit of functionality so it doesn't matter much either way,
> > and it doesn't seem at all burdonsome to maintain.
> "Marginal" ... same word I used elsethread. :-)
> > I think using "--cl=''" for the UI is lame and driven by just letting the
> > UI be dictated by the implementation.
> I know what you're saying, and you may be right about how we originally
> arrived at this UI. I do recall that we considered the very things you
> suggested, but didn't stick with them for various reasons:
> "--cl=none" -- introduces a reserved changelist name "none" that
> someone, somewhere might already be really using.
> "--no-changelist" -- implies that directories are included.
> In a way, the current UI -- as ugly as it may seem -- turns out to actually
> align pretty well with the real behaviors of the feature: the very presence
> of the --cl option at all always indicates that the subcommand's operation
> will be limited to things that can be assigned to changelists (files only),
> and the empty-string argument says "... and of those files, recognize only
> the ones with no changelist".
> If we decide instead that what is desired is a way to say "all files *and
> directories* not in a changelist", then I agree: --cl="" is bust, and
> something like --without-changelist (--wo-cl?) makes more sense.

I think that one of the major problems is that mixing our depth handling and changelists doesn't work.

Currently commands only work 'as expected' with depth infinity and a changelist filter, and then for directories the depth infinity has side effects.

In most cases changelists for directories *would* work, if that makes the client pass the changelist-selected targets to the library, but then with depth empty.

E.g. since 1.7 you can 'svn ci --depth empty DIR' a directory copy, but using changelists would require a depth infinity walk to find the targets.

In AnkhSVN and TortoiseSVN the changelist is processed one level higher up in the client UI, and here allowing to store a changelist for directories makes sense.

So maybe we should split the depth for the target walk (filling the target list), from the operation depth for the relevant commands (maybe always depth empty?) for changelist mode?

Received on 2013-01-05 00:52:10 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.