[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [PATCH] fix for diff optimization bug

From: Bert Huijben <bert_at_qqmail.nl>
Date: Sat, 29 Dec 2012 17:46:27 +0100

> -----Original Message-----
> From: Hideki IWAMOTO [mailto:h-iwamoto_at_kit.hi-ho.ne.jp]
> Sent: zaterdag 29 december 2012 17:28
> To: Bert Huijben
> Cc: dev_at_subversion.apache.org
> Subject: Re: [PATCH] fix for diff optimization bug
>
> Hi.
>
> > I retraced your steps and applied your patch with some small tweaks in
> > r1426752
> (https://svn.apache.org/viewvc?view=revision&revision=r1426752)
>
> There is a small difference in
> issu4133-trunk.patch which I attached to e-mail and
> issu4133-trunk-2.patch which I registered into issue tracker.
> Would you also apply this?

It would be much easier if you told what differences there are between your
patches instead of making me find out myself. (Or you could just send a new
patch)

I think I applied the change you refer to in r1426784.

For future patches I would recommend writing a log message following our
community guidelines
(http://subversion.apache.org/docs/community-guide/conventions.html#log-mess
ages)

This makes the review of your patch (and committing the patch) much easier
for others.

Thanks,

        Bert
Received on 2012-12-29 17:47:06 CET

This is an archived mail posted to the Subversion Dev mailing list.