Re: [PATCH] Update to out-of-date code comments
From: Daniel Shahaf <danielsh_at_elego.de>
Date: Thu, 27 Dec 2012 19:24:44 +0200
Gabriela Gibson wrote on Thu, Dec 27, 2012 at 14:13:01 +0000:
"the function get_lock()"
> * subversion/svnrdump/load_editor.c:
Two spaces indent, not four. Also we prefer imperative to past tense
> Patch by Gabriela Gibson <gabriela.gibson_at_gmail.com>
Colon after 'by'.
> Index: subversion/tests/svn_test_main.c
Typo in filename ("tests" singular).
> /* Acquire a lock (of sorts) on the repository associated with the
Why did you s/duplicate/similar/? I think the former is better (for its
That's all. All in all I'm not sure whether to just apply it or wait
This is an archived mail posted to the Subversion Dev mailing list.