> Author: pburba
> Date: Thu Dec 20 21:19:08 2012
> New Revision: 1424708
>
> URL: http://svn.apache.org/viewvc?rev=1424708&view=rev
> Log:
> Store repos root relative paths in NODES.INHERITED_PROPS rather than full
> URLs.
Glad to see this, overall. One concern:
> See http://svn.haxx.se/dev/archive-2012-12/0427.shtml
>
> * subversion/include/svn_ra.h
>
> (svn_ra_get_inherited_props): Add a new argument allowing the API to
> retrieve an array of svn_prop_inherited_item_t items with the path_or_url
> member set to either a URL or (new) a repos relpath.
Eww. Can't we have this function do one thing and do it well?
Let the higher layers convert to full URLs if they need to.
> * subversion/libsvn_client/client.h
>
> (svn_client__get_inheritable_props): Same as svn_ra_get_inherited_props().
>
> * subversion/libsvn_client/externals.c
> (switch_file_external):
> * subversion/libsvn_client/update.c
> (update_internal):
> * subversion/libsvn_client/switch.c
> (switch_internal):
> Update calls to svn_ra_get_inherited_props() in all these functions,
> getting svn_prop_inherited_item_t's keyed on relpaths rather than
> URLs as before.
>
> * subversion/libsvn_client/iprops.c
>
> (svn_client__get_inheritable_props): Implement new argument.
>
> * subversion/libsvn_client/prop_commands.c
>
> (remote_propget,
> remote_proplist): Update call to svn_ra_get_inherited_props(),
> getting svn_prop_inherited_item_t's keyed on URLs as before.
>
> * subversion/libsvn_ra/ra_loader.c
>
> (svn_ra_get_inherited_props): Implement new argument.
>
> * subversion/libsvn_wc/wc_db.c
>
> (read_inherited_props_baton_t): Add new member tracking the repos root URL.
>
> (db_read_inherited_props): Convert repos rel paths to URLs in output.
Same here.
> (svn_wc__db_read_inherited_props): Initialize new baton member.
- Julian
Received on 2012-12-20 22:57:02 CET