Re: -Werror flag set unconditionally

On 20.12.2012 04:31, Arfrever Frehtes Taifersar Arahesis wrote:
> 2012-12-20 03:39:30 Branko Čibej napisał(a):
>> I found the following in configure.ac which unconditionally adds a
>> -Werror flag:
>>
>> dnl Add -Werror=implicit-function-declaration to CFLAGS
>> CFLAGS_KEEP="$CFLAGS"
>> CFLAGS="$CFLAGS_KEEP -Werror=implicit-function-declaration"
>> AC_COMPILE_IFELSE([AC_LANG_SOURCE([[]])], [CFLAGS_KEEP="$CFLAGS"])
>> CFLAGS="$CFLAGS_KEEP"
>>
>>
>> I'm almost sure this should only be done in maintainer-mode?
> -Werror != -Werror=implicit-function-declaration

Yes, yes, I just didn't want to write a mile-long mail subject line.

> We want to always use -Werror=implicit-function-declaration (if compiler supports it)

... which we don't check ...

> to ensure that nobody forgets to include required headers.

I'm not convinced. We add -Wmissing-prototypes in maintainer-mode. Why
would we act differently in this case?

-- Brane

-- 
Branko Čibej
Director of Subversion | WANdisco | www.wandisco.com