Ben Reser wrote:
> I've finished the work needed to implement in-repo-authz on the branch.
>
> I'd like to merge this code back to trunk. If there are no objections
> I'll merge it into trunk next week.
>
> Please review my changes. You can view the overall set of changes
> that would be merged with:
> svn diff -x-p http://svn.apache.org/repos/asf/subversion/trunk@1423749
> http://svn.apache.org/repos/asf/subversion/branches/in-repo-authz@1423749
>
> The high level details of the changes and some performance testing of
> the changes are on the wiki here:
> http://wiki.apache.org/subversion/InRepoAuthz
>
> Perf testing has showing very little in the way of performance impact
> of this feature.
>
> Details of the non-obvious changes are as follows:
> svn_config_parse() added which allows parsing a configuration file
> from a stream rather than a file.
> Errors while parsing config files will now have the file and the line
> the error occurs in separate errors since parsing the stream is now
> abstracted from reading it in.
> svn_path_is_repos_relative_url() and
> svn_path_resolve_repos_relative_url() moved from private functions in
> libsvn_client/cmdline.c to public functions.
> svn_repos_authz_read2() added, which knows how to read authz files
> from within the repo.
> svnserve --config-file no longer caches the password and authz db
> files specified in the config file passed to the option. They are
> loaded on each connection, just like every other mode of operation for
> svnserve.
> mod_authz_svn has had the logging of svn_error_t structs generalized
> and now logs the full chain.
Just a thought. Some of these changes are significant (in both lines touched and functionality) on their own. One that stands out is "svnserve --config-file no longer caches the password and authz db ...". Would it be a good idea (and not too much work) to merge that first, as a separate change?
- Julian
Received on 2012-12-19 15:58:06 CET