[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Improve error handling in svn_ra_serf__replay_range()

From: Daniel Shahaf <danielsh_at_elego.de>
Date: Wed, 19 Dec 2012 15:57:36 +0200

> +@SkipUnless(svntest.main.is_ra_type_dav)
> +def dump_url_not_in_head(sbox) :

Spurious whitespace.

> + "dump: URL deleted in HEAD should return error"
> + sbox.build(create_wc = False)
> +
> + E_url = sbox.repo_url + '/A/B/E'
>
> + # Delete directory 'E'from repository.
> + svntest.actions.run_and_verify_svn(None, None, [], "rm", E_url, "-m",
> + "delete 'E'")

Can't you pass read_only=True to sbox.build() and then use EE rather
than E here?

I note that 'svnadmin create r; svnrdump dump file://$PWD/r/foo' does
not error --- maybe your patch fixes that too?

>
> + expected_dump_fail_err_re = "svnrdump: E160013: '.*' path not found"
> +
> + # Returns error as in issue #4100.
> + svntest.actions.run_and_verify_svnrdump(None, svntest.verify.AnyOutput,
> + expected_dump_fail_err_re, 1, '-q',
> + 'dump', E_url)
> +
> +
> +#----------------------------------------------------------------------
> +
> +
> ########################################################################
> # Run the tests
>
Received on 2012-12-19 14:58:29 CET

This is an archived mail posted to the Subversion Dev mailing list.