Re: [PATCH] Fix for "\r" in "svnrdump load" (issue 4263)
From: Ben Reser <ben_at_reser.org>
Date: Mon, 17 Dec 2012 18:09:09 -0800
On Mon, Dec 17, 2012 at 5:40 PM, Gabriela Gibson
Looks pretty good to me with a few relatively minor comments.
I'd remove the test for svn_prop_needs_translation() in
I'd include the argument names in your comment for the
You've got a couple spurious whitespace changes in your patch that I
You have tab indentation in your code, we only use spaces.
> (svn_rdump__normalize_props): Refactored to move logic into
We usually only indent that second line with 2 spaces. (though I'm
Function references in the descriptive text is usually written as
This is an archived mail posted to the Subversion Dev mailing list.