[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Improve error handling in svn_ra_serf__replay_range()

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Mon, 17 Dec 2012 16:04:34 +0000

vijay <vijay_at_collab.net> writes:

> The function svn_ra_serf__replay_range() doesn't return any error
> while running 'svnrdump dump -rN:M <URL-deleted-in-HEAD>'[Issue #4100].
> It behaves as if the dump completed successfully.
>
> * subversion/libsvn_ra_serf/replay.c
> (svn_ra_serf__replay_range): Handle the errors from server's response as
> well as any errors found while running the serf loop.

Consider adding a regression test to svnrdump_tests.py.

> /* Run the serf loop. */
> - SVN_ERR(svn_ra_serf__context_run_wait(&replay_ctx->done, session, pool));
> + err = svn_ra_serf__context_run_wait(&replay_ctx->done, session, pool);
>
> + /* Handle the errors from server's response as well as any errors
> + found while running the serf loop. */
> + SVN_ERR(svn_error_compose_create(
> + svn_ra_serf__error_on_status(handler->sline.code,
> + handler->path,
> + handler->location),
> + err));
> +

When I see this sort of change I wonder if it needs to be applied
anywhere else. The call in update.c:svn_ra_serf__get_file also uses
SVN_ERR. Does it need the same fix?

-- 
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download
Received on 2012-12-17 17:05:14 CET

This is an archived mail posted to the Subversion Dev mailing list.