Re: svn commit: r1422706 - in /subversion/trunk/subversion: libsvn_subr/opt.c tests/cmdline/svntest/main.py

On 17.12.2012 11:23, Bert Huijben wrote:
>
>> -----Original Message-----
>> From: Branko Čibej [mailto:brane_at_wandisco.com]
>> Sent: maandag 17 december 2012 11:19
>> To: dev_at_subversion.apache.org
>> Subject: Re: svn commit: r1422706 - in /subversion/trunk/subversion:
>> libsvn_subr/opt.c tests/cmdline/svntest/main.py
>>
>> On 17.12.2012 09:47, Bert Huijben wrote:
>>> I think we should suppress this warning on Windows when the CryptoAPI
>>> encryption is enabled (read: +- always) to avoid unneeded user questions.
>> I rather think we should disable plaintext password storage by default,
>> I don't care about Windows, and let people enable it explicitly.
>>
>>> And I’m not sure what to think of the color escape strings...
>>> Do these work on any not Windows os with any terminal settings?
>> These aren't used at all on Windows. They work everywhere on Unix.
>>
>>> (We currently only use these in the test suite and the result is plainly
>>> visisble on the buildbot log)
>> That's funny.
>>
>> if not sys.stdout.isatty() or sys.platform == 'win32':
>> TextColors.disable()
>>
>> They're unconditionally disabled on Windows, so if stdout.isatty()
>> returns True, I don't know /what/ the buildbot does.
> The unix buildbot just outputs them literally. The Windows buildbot works just fine.
>
> And I'm pretty sure there are terminal settings where you should do something else to make text stand out. (I assume this escape is for bold?)

What I'm saying is, buildbot output is clearly redirected to a file, so
isatty() should return False.

-- Brane

-- 
Branko Čibej
Director of Subversion | WANdisco | www.wandisco.com