[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1422042 - /subversion/trunk/subversion/libsvn_fs_fs/rep-cache.c

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Fri, 14 Dec 2012 23:12:32 +0000

Julian Foad <julianfoad_at_btopenworld.com> writes:

>> URL: http://svn.apache.org/viewvc?rev=1422042&view=rev
>
>> Log:
>> Fix issue 4210, rep-cache not reseting SQLite statements on error.
>
> I noticed the other day that WC DB code in many places fails to reset
> stmts on error, but that svn_sqlite__get_statement() automatically
> resets the stmt if it hasn't been reset since last used.  Does this
> tally with your understanding of what you just fixed in the rep-cache
> -- that is, it could be described as a functionally harmless coding
> style violation?

I'm not really sure. We go to a lot of trouble to reset statements in
some places. Perhaps it doesn't really matter in this case because the
server only uses a small number of statements so there can never be a
large number of statements needing to be reset?

> If so it would be good to say so in log msg & issue to indicate it
> doesn't need back-porting.

-- 
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download
Received on 2012-12-15 00:13:10 CET

This is an archived mail posted to the Subversion Dev mailing list.