[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1409652 - /subversion/trunk/subversion/tests/cmdline/patch_tests.py

From: Paul Burba <ptburba_at_gmail.com>
Date: Thu, 13 Dec 2012 19:10:17 -0500

On Thu, Nov 15, 2012 at 12:40 AM, <danielsh_at_apache.org> wrote:
> Author: danielsh
> Date: Thu Nov 15 05:40:40 2012
> New Revision: 1409652
>
> URL: http://svn.apache.org/viewvc?rev=1409652&view=rev
> Log:
> Add a skeleton XFail test. There is no issue number yet, but the bug is being
> discussed on users@.

Hi Daniel,

Was an issue ever filed for this? More importantly, is it a
regression or does it otherwise block 1.8?

> * subversion/tests/cmdline/patch_tests.py
> (patch_change_symlink_target): New.
> (test_list): Run it.
>
> Modified:
> subversion/trunk/subversion/tests/cmdline/patch_tests.py
>
> Modified: subversion/trunk/subversion/tests/cmdline/patch_tests.py
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/cmdline/patch_tests.py?rev=1409652&r1=1409651&r2=1409652&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/tests/cmdline/patch_tests.py (original)
> +++ subversion/trunk/subversion/tests/cmdline/patch_tests.py Thu Nov 15 05:40:40 2012
> @@ -4201,6 +4201,40 @@ def patch_git_with_index_line(sbox):
> 1, # check-props
> 1) # dry-run
>
> +@XFail(svntest.main.is_posix_os)
> +def patch_change_symlink_target(sbox):
> + "patch changes symlink target"
> +
> + sbox.build()
> + wc_dir = sbox.wc_dir
> + patch_file_path = make_patch_path(sbox)
> + svntest.main.file_write(patch_file_path, '\n'.join([
> + "Index: link",
> + "===================================================================",
> + "--- iota (revision 1)",
> + "+++ iota (working copy)",
> + "@@ -1 +1 @@",
> + "-link foo",
> + "\\ No newline at end of file",
> + "+link bar",
> + "\\ No newline at end of file",
> + "",
> + ]))
> +
> + # r2
> + sbox.simple_add_symlink('target', 'link')
> + sbox.simple_commit()
> +
> + expected_output = [
> + 'M %s\n' % sbox.ospath('link'),
> + ]
> +
> + # This currently fails.
> + # TODO: when it passes, verify that the on-disk 'link' is correct ---
> + # symlink to 'bar' (or "link bar" on non-HAVE_SYMLINK platforms)
> + svntest.actions.run_and_verify_svn(None, "U *link", [],
> + 'patch', patch_file_path, wc_dir)
> +
> ########################################################################
> #Run the tests
>
> @@ -4246,6 +4280,7 @@ test_list = [ None,
> patch_target_no_eol_at_eof,
> patch_add_and_delete,
> patch_git_with_index_line,
> + patch_change_symlink_target,
> ]
>
> if __name__ == '__main__':
>
>

-- 
Paul T. Burba
CollabNet, Inc. -- www.collab.net -- Enterprise Cloud Development
Skype: ptburba
Received on 2012-12-14 01:10:52 CET

This is an archived mail posted to the Subversion Dev mailing list.