[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Test for line ending bug in svnrdump (issue 4263)

From: Daniel Shahaf <danielsh_at_elego.de>
Date: Thu, 13 Dec 2012 00:06:34 +0200

Ben Reser wrote on Wed, Dec 12, 2012 at 13:57:30 -0800:
> On Tue, Dec 11, 2012 at 5:59 PM, Ben Reser <ben_at_reser.org> wrote:
> > I'd say that replacing '\r' with a '<space>' is wrong. That would
> > change the meaning of some properties. E.G. svn:ignore, svn:externals
> > which use lines to handle individual records within them.
>
> To be more explicit, I think you should change CR or CRLF into LF.

I've applied your patch Gabriela, with a tweak to the log message and
with the addition of an expected_dumpfile_path parameter. Currently the
test checks what Ben said --- which is also consistent with what you and
danielsh suggested in earlier emails.

Naturally we can change the test's expectations if down the road we
decide the correct behaviour is something else.

Thanks for the patch!

Daniel

P.S. This thread was an unusually long one, for a patch that adds about
a dozen lines of code.
Received on 2012-12-12 23:07:39 CET

This is an archived mail posted to the Subversion Dev mailing list.