[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Test for line ending bug in svnrdump (issue 4263)

From: Ben Reser <ben_at_reser.org>
Date: Tue, 11 Dec 2012 18:52:46 -0800

On Tue, Dec 11, 2012 at 6:02 PM, Daniel Shahaf <danielsh_at_elego.de> wrote:
> We have code on the client side that removes \r from the log message
> supplied by the user. (I don't really remember whether that is in 'svn' (the
> cmdline client) or in libsvn_client.)

That would be the svn_subst_translate_string2() call in
svn_cl__get_log_message() which is part of the cmdline client.

I was thinking we had some code to remove trailing whitespace from
logs, but I just looked and we don't.

I'd missed that copy-bad-line-endings.dump had a trailing CRLF not
just a trailing CR. The CRLF is being converted to just a LF because
we are passing TRUE as the repair argument to the
svn_subst_translate_string2() call in svnsync.
Received on 2012-12-12 03:53:31 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.