[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Test for line ending bug in svnrdump (issue 4263)

From: Daniel Shahaf <danielsh_at_elego.de>
Date: Wed, 12 Dec 2012 03:54:55 +0200

Gabriela Gibson wrote on Wed, Dec 12, 2012 at 01:16:34 +0000:
> The differences between copy-bad-line-endings.expected.dump and
> copy-bad-line-endings.dump appear to be:
> 1. '\r' in the middle of a line is replaced by '\n'.
> 2. '\r' at the end of a line is deleted.

Actually what happens in (2) is that a CRLF at the end of the line
becomes LF. (How to tell? Look at svn_hash_write2() for the
serialisation format description, then count the bytes within the field.
The second \r is byte 48 in a 49-byte field. Byte 49 is a \n.)

> Let's call this "option 1".
> I had in mind to replace '\r' with '<space>'.
> This would be option 2.
> Which is the prefered option?

Whatever is consistent with how we handle \r elsewhere --- eg, in
svnsync, 'svnadmin dump' (which I think dumps \r literally), and
'svnrdump dump'.

We might just need to reuse copy-bad-line-endings.expected.dump --- but
you're correct that that is not a priori obvious.



> Regards
> Gabriela
Received on 2012-12-12 02:55:47 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.