[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Test for line ending bug in svnrdump (issue 4263)

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Tue, 11 Dec 2012 18:14:22 -0500

On 12/11/2012 06:01 PM, Daniel Shahaf wrote:
> Gabriela Gibson wrote on Tue, Dec 11, 2012 at 22:18:54 +0000:
>> On 11/12/12 00:46, Daniel Shahaf wrote:
>>
>>> Need parentheses around the symbol name. Lines should be wrapped at 80
>>> characters and subsequent lines indented.
>>
>> The web page instructions[1] need updating because they doesn't mention
>> this and so, I was trying to stay under a 72 character limit for the
>> mailing list.
>>
>
> It seems
> http://subversion.apache.org/docs/community-guide/conventions#log-messages
> doesn't mention that either. Though I believe we recommend 79 columns
> for code.

http://subversion.apache.org/docs/community-guide/conventions.html#other-conventions
recommends 79 columns for code. "Restrict lines to 79 columns, so that code
will display well in a minimal standard display window."

We should probably link to the "Coding Conventions" section from the "Patch
submission guidelines" section just to be thorough.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Enterprise Cloud Development

Received on 2012-12-12 00:14:59 CET

This is an archived mail posted to the Subversion Dev mailing list.