[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Test for line ending bug in svnrdump (issue 4263)

From: Gabriela Gibson <gabriela.gibson_at_gmail.com>
Date: Tue, 11 Dec 2012 22:18:54 +0000

On 11/12/12 00:46, Daniel Shahaf wrote:

> Need parentheses around the symbol name. Lines should be wrapped at 80
> characters and subsequent lines indented.

The web page instructions[1] need updating because they doesn't mention
this and so, I was trying to stay under a 72 character limit for the
mailing list.

> The test needs an @XFail decorator, since it currently FAILs. And an
> @Issue decorator, to associate it with #4263.

I hope to have corrected all outstanding issues in the attached files.

> Re your other mail about OPW, you shouldn't let yourself be blocked by
> this --- while this patch is outstanding, you should feel free to work
> on another patch. The natural choice would be the C patch that turns
> this test from XFAIL to PASS.

I will attempt to do just this. Also your tip with the libtool was much
appreciated, thank you very much :)


[1] http://subversion.apache.org/docs/community-guide/general.html#patches

Received on 2012-12-11 23:19:28 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.