[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Literals in wc SQLite queries

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Tue, 11 Dec 2012 10:14:07 +0000

Daniel Shahaf <danielsh_at_elego.de> writes:

> Philip Martin wrote on Mon, Dec 10, 2012 at 17:49:44 +0000:
>> Daniel Shahaf <danielsh_at_elego.de> writes:
>>
>> > Philip - perhaps you can move the relevant definitions to that header?
>> > Then I'll follow up with a transform_sql.py patch.
>>
>> OK, I've done that. I didn't annotate the maps or elements in any way.
>
> Implemented. Please note the question embedded in the r1419771 log
> message. (The code added in r1419817 might be relevant, too, in case
> both the node-kind and the depth maps have an "unknown" map member.)

'unknown' for depth corresponds to svn_depth_unknown while 'unknown' for
kind corresponds to svn_kind_unknown. As C enums these are different
values.

You changed STMT_HAS_SPARSE_NODES to use the kind mapping for depth.
This will work since the numeric values are not involved, but it feels
wrong to me: we should introduce a svn_depth_t map.

-- 
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download
Received on 2012-12-11 11:14:46 CET

This is an archived mail posted to the Subversion Dev mailing list.