Re: [PATCH] Implement svnadmin verify --keep-going
From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Mon, 10 Dec 2012 14:45:57 +0000 (GMT)
Prabhu Gnana Sundar
> This patch is a follow up of the long discussion we had in thread . This
Thank you for the patch.
Please will you summarize the issues that were raised in the previous discussion and how you have chosen to proceed. I'm thinking in particular of the discussion about how the output is notified -- how to display each error, on what output stream, and what to print at the end of the whole verification and what exit code to return. There may have been other issues too.
I scanned quickly through your patch and I noticed one place where you declare a local function without the 'static' keyword. I expect this should give a warning when you compile it, so please will you compile with and without your patch applied and check for any additional compiler warnings that your patch adds.
This is an archived mail posted to the Subversion Dev mailing list.