[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Implement svnadmin verify --keep-going

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Mon, 10 Dec 2012 14:45:57 +0000 (GMT)

Prabhu Gnana Sundar

> This patch is a follow up of the long discussion we had in thread [1]. This
> patch implements a new switch "--keep-going" to svnadmin verify.
> If "--keep-going" is set(True), svnadmin verify would continue to run
> till verifying all the revisions i.e, it would not stop at the very first
> occurance of a corruption/error found in the repo and would report corruptions
> wherever found.
> I have worked on your suggestions and inputs for this patch. Kindly share your
> thoughts. Attaching the patch and the log message with this mail.

Thank you for the patch.

Please will you summarize the issues that were raised in the previous discussion and how you have chosen to proceed.  I'm thinking in particular of the discussion about how the output is notified -- how to display each error, on what output stream, and what to print at the end of the whole verification and what exit code to return.  There may have been other issues too.

I scanned quickly through your patch and I noticed one place where you declare a local function without the 'static' keyword.  I expect this should give a warning when you compile it, so please will you compile with and without your patch applied and check for any additional compiler warnings that your patch adds.

- Julian
Received on 2012-12-10 15:46:36 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.